Adding more API tests

src/cmi/common.js

@@ -59,6 +59,15 @@ export class BaseCMI {
   jsonString = false;
   #initialized = false;
 
+  /**
+   * Constructor for BaseCMI, just marks the class as abstract
+   */
+  constructor() {
+    if (new.target === BaseCMI) {
+      throw new TypeError('Cannot construct BaseCMI instances directly');
+    }
+  }
+
   /**
    * Getter for #initialized
    * @return {boolean}
@@ -101,22 +110,17 @@ export class CMIScore extends BaseCMI {
       }) {
     super();
 
-    this.#_children = score_children ?
-        score_children :
+    this.#_children = score_children ||
         scorm12_constants.score_children;
     this.#_score_range = !score_range ? false : scorm12_regex.score_range;
     this.#max = (max || max === '') ? max : '100';
-    this.#_invalid_error_code = invalidErrorCode ?
-        invalidErrorCode :
+    this.#_invalid_error_code = invalidErrorCode ||
         scorm12_error_codes.INVALID_SET_VALUE;
-    this.#_invalid_type_code = invalidTypeCode ?
-        invalidTypeCode :
+    this.#_invalid_type_code = invalidTypeCode ||
         scorm12_error_codes.TYPE_MISMATCH;
-    this.#_invalid_range_code = invalidRangeCode ?
-        invalidRangeCode :
+    this.#_invalid_range_code = invalidRangeCode ||
         scorm12_error_codes.VALUE_OUT_OF_RANGE;
-    this.#_decimal_regex = decimalRegex ?
-        decimalRegex :
+    this.#_decimal_regex = decimalRegex ||
         scorm12_regex.CMIDecimal;
   }
 
@@ -249,7 +253,6 @@ export class CMIArray extends BaseCMI {
   /**
    * Getter for _children
    * @return {*}
-   * @private
    */
   get _children() {
     return this.#_children;
@@ -258,7 +261,6 @@ export class CMIArray extends BaseCMI {
   /**
    * Setter for _children. Just throws an error.
    * @param {string} _children
-   * @private
    */
   set _children(_children) {
     throw new ValidationError(this.#errorCode);
@@ -267,7 +269,6 @@ export class CMIArray extends BaseCMI {
   /**
    * Getter for _count
    * @return {number}
-   * @private
    */
   get _count() {
     return this.childArray.length;
@@ -276,7 +277,6 @@ export class CMIArray extends BaseCMI {
   /**
    * Setter for _count. Just throws an error.
    * @param {number} _count
-   * @private
    */
   set _count(_count) {
     throw new ValidationError(this.#errorCode);

src/cmi/scorm12_cmi.js

@@ -39,26 +39,35 @@ function throwInvalidValueError() {
  * Helper method, no reason to have to pass the same error codes every time
  * @param {*} value
  * @param {string} regexPattern
+ * @param {boolean} allowEmptyString
  * @return {boolean}
  */
-export function check12ValidFormat(value: String, regexPattern: String) {
+export function check12ValidFormat(
+    value: String,
+    regexPattern: String,
+    allowEmptyString?: boolean) {
   return checkValidFormat(value, regexPattern,
-      scorm12_error_codes.TYPE_MISMATCH);
+      scorm12_error_codes.TYPE_MISMATCH, allowEmptyString);
 }
 
 /**
  * Helper method, no reason to have to pass the same error codes every time
  * @param {*} value
  * @param {string} rangePattern
+ * @param {boolean} allowEmptyString
  * @return {boolean}
  */
-export function check12ValidRange(value: any, rangePattern: String) {
+export function check12ValidRange(
+    value: any,
+    rangePattern: String,
+    allowEmptyString?: boolean) {
   return checkValidRange(value, rangePattern,
-      scorm12_error_codes.VALUE_OUT_OF_RANGE);
+      scorm12_error_codes.VALUE_OUT_OF_RANGE, allowEmptyString);
 }
 
 /**
  * Class representing the cmi object for SCORM 1.2
+ * @extends BaseCMI
  */
 export class CMI extends BaseCMI {
   #_children = '';
@@ -138,7 +147,6 @@ export class CMI extends BaseCMI {
   /**
    * Getter for #_version
    * @return {string}
-   * @private
    */
   get _version() {
     return this.#_version;
@@ -147,7 +155,6 @@ export class CMI extends BaseCMI {
   /**
    * Setter for #_version. Just throws an error.
    * @param {string} _version
-   * @private
    */
   set _version(_version) {
     throwInvalidValueError();
@@ -156,7 +163,6 @@ export class CMI extends BaseCMI {
   /**
    * Getter for #_children
    * @return {string}
-   * @private
    */
   get _children() {
     return this.#_children;
@@ -165,7 +171,6 @@ export class CMI extends BaseCMI {
   /**
    * Setter for #_version. Just throws an error.
    * @param {string} _children
-   * @private
    */
   set _children(_children) {
     throwInvalidValueError();
@@ -244,6 +249,7 @@ export class CMI extends BaseCMI {
 
 /**
  * Class representing the cmi.core object
+ * @extends BaseCMI
  */
 class CMICore extends BaseCMI {
   /**
@@ -511,6 +517,7 @@ class CMICore extends BaseCMI {
 
 /**
  * Class representing SCORM 1.2's cmi.objectives object
+ * @extends CMIArray
  */
 class CMIObjectives extends CMIArray {
   /**
@@ -526,6 +533,7 @@ class CMIObjectives extends CMIArray {
 
 /**
  * Class representing SCORM 1.2's cmi.student_data object
+ * @extends BaseCMI
  */
 export class CMIStudentData extends BaseCMI {
   #_children;
@@ -642,6 +650,7 @@ export class CMIStudentData extends BaseCMI {
 
 /**
  * Class representing SCORM 1.2's cmi.student_preference object
+ * @extends BaseCMI
  */
 class CMIStudentPreference extends BaseCMI {
   /**
@@ -777,6 +786,7 @@ class CMIStudentPreference extends BaseCMI {
 
 /**
  * Class representing SCORM 1.2's cmi.interactions object
+ * @extends BaseCMI
  */
 class CMIInteractions extends CMIArray {
   /**
@@ -792,6 +802,7 @@ class CMIInteractions extends CMIArray {
 
 /**
  * Class representing SCORM 1.2's cmi.interactions.n object
+ * @extends BaseCMI
  */
 export class CMIInteractionsObject extends BaseCMI {
   /**
@@ -915,7 +926,7 @@ export class CMIInteractionsObject extends BaseCMI {
    * @param {string} student_response
    */
   set student_response(student_response) {
-    if (check12ValidFormat(student_response, regex.CMIFeedback)) {
+    if (check12ValidFormat(student_response, regex.CMIFeedback, true)) {
       this.#student_response = student_response;
     }
   }
@@ -993,6 +1004,7 @@ export class CMIInteractionsObject extends BaseCMI {
 
 /**
  * Class representing SCORM 1.2's cmi.objectives.n object
+ * @extends BaseCMI
  */
 export class CMIObjectivesObject extends BaseCMI {
   /**
@@ -1074,6 +1086,7 @@ export class CMIObjectivesObject extends BaseCMI {
 
 /**
  * Class representing SCORM 1.2's cmi.interactions.n.objectives.n object
+ * @extends BaseCMI
  */
 export class CMIInteractionsObjectivesObject extends BaseCMI {
   /**
@@ -1123,6 +1136,7 @@ export class CMIInteractionsObjectivesObject extends BaseCMI {
 
 /**
  * Class representing SCORM 1.2's cmi.interactions.correct_responses.n object
+ * @extends BaseCMI
  */
 export class CMIInteractionsCorrectResponsesObject extends BaseCMI {
   /**
@@ -1147,7 +1161,7 @@ export class CMIInteractionsCorrectResponsesObject extends BaseCMI {
    * @param {string} pattern
    */
   set pattern(pattern) {
-    if (check12ValidFormat(pattern, regex.CMIFeedback)) {
+    if (check12ValidFormat(pattern, regex.CMIFeedback, true)) {
       this.#pattern = pattern;
     }
   }