From 7cdbf4c4c04ea0491bcb26116518230e0cae6184 Mon Sep 17 00:00:00 2001
From: Jonathan Putney <jputney@noverant.com>
Date: Thu, 14 Nov 2019 21:53:32 -0500
Subject: [PATCH] Fixing a few tests

---
 src/constants/field_values.js |  4 ++--
 test/AICC.spec.js             | 23 +++++++++++++++++++++++
 test/Scorm12API.spec.js       | 25 +++++++++++++++++++++++++
 test/cmi/scorm12_cmi.spec.js  | 13 ++++++-------
 4 files changed, 56 insertions(+), 9 deletions(-)

diff --git a/src/constants/field_values.js b/src/constants/field_values.js
index e34a6fd..d88eec6 100644
--- a/src/constants/field_values.js
+++ b/src/constants/field_values.js
@@ -161,13 +161,13 @@ export const scorm12_values = {
       'P1DT23H59M59S',
     ],
 
-    validTimestamp: [
+    validTimespan: [
       '10:06:57',
       '00:00:01.56',
       '23:59:59',
       '47:59:59',
     ],
-    invalidTimestamp: [
+    invalidTimespan: [
       '06:5:13',
       '23:59:59.123',
       'P1DT23H59M59S',
diff --git a/test/AICC.spec.js b/test/AICC.spec.js
index eda20e0..0d55c58 100644
--- a/test/AICC.spec.js
+++ b/test/AICC.spec.js
@@ -244,6 +244,29 @@ describe('AICC API Tests', () => {
         fieldName: 'cmi.interactions.0.id',
         valueToTest: 'AAA',
       });
+      h.checkLMSSetValue({
+        api: apiInitialized(),
+        fieldName: 'cmi.evaluation.comments.0.content',
+        valueToTest: 'AAA',
+      });
+      h.checkLMSSetValue({
+        api: apiInitialized(),
+        fieldName: 'cmi.student_data.tries.0.score.max',
+        valueToTest: '100',
+      });
     });
   });
+
+  describe('replaceWithAnotherScormAPI()', () => {
+    const firstAPI = api();
+    const secondAPI = api();
+
+    firstAPI.cmi.core.student_id = 'student_1';
+    secondAPI.cmi.core.student_id = 'student_2';
+
+    firstAPI.replaceWithAnotherScormAPI(secondAPI);
+    expect(
+        firstAPI.cmi.core.student_id,
+    ).to.equal('student_2');
+  });
 });
diff --git a/test/Scorm12API.spec.js b/test/Scorm12API.spec.js
index 4973768..0d0e8eb 100644
--- a/test/Scorm12API.spec.js
+++ b/test/Scorm12API.spec.js
@@ -151,6 +151,16 @@ describe('SCORM 1.2 API Tests', () => {
       });
     });
 
+    describe('Read and Write Properties - Should Success', () => {
+      h.checkLMSGetValue({
+        api: apiInitialized(),
+        fieldName: 'cmi.interactions.0.objectives.0.id',
+        initializeFirst: true,
+        initializationValue: 'AAA',
+        expectedValue: 'AAA',
+      });
+    });
+
     describe('Write-Only Properties - Should Always Fail', () => {
       h.checkLMSGetValue({
         api: apiInitialized(),
@@ -214,6 +224,8 @@ describe('SCORM 1.2 API Tests', () => {
         api: apiInitialized(),
         fieldName: 'cmi.interactions.0.correct_responses.0.pattern',
         initializeFirst: true,
+        initializationValue: 'AAA',
+        expectedValue: 'AAA',
         expectedError: scorm12_error_codes.WRITE_ONLY_ELEMENT,
       });
     });
@@ -246,4 +258,17 @@ describe('SCORM 1.2 API Tests', () => {
       });
     });
   });
+
+  describe('replaceWithAnotherScormAPI()', () => {
+    const firstAPI = api();
+    const secondAPI = api();
+
+    firstAPI.cmi.core.student_id = 'student_1';
+    secondAPI.cmi.core.student_id = 'student_2';
+
+    firstAPI.replaceWithAnotherScormAPI(secondAPI);
+    expect(
+        firstAPI.cmi.core.student_id,
+    ).to.equal('student_2');
+  });
 });
diff --git a/test/cmi/scorm12_cmi.spec.js b/test/cmi/scorm12_cmi.spec.js
index b15fb8b..b56ac34 100644
--- a/test/cmi/scorm12_cmi.spec.js
+++ b/test/cmi/scorm12_cmi.spec.js
@@ -195,8 +195,8 @@ describe('SCORM 1.2 CMI Tests', () => {
       h.checkValidValues({
         cmi: cmi(),
         fieldName: 'cmi.core.session_time',
-        validValues: scorm12_values.validHHMMSS,
-        invalidValues: scorm12_values.invalidHHMMSS,
+        validValues: scorm12_values.validTimespan,
+        invalidValues: scorm12_values.invalidTimespan,
       });
 
       /**
@@ -458,8 +458,8 @@ describe('SCORM 1.2 CMI Tests', () => {
       h.checkValidValues({
         cmi: cmiInitialized(),
         fieldName: 'cmi.core.session_time',
-        validValues: scorm12_values.validHHMMSS,
-        invalidValues: scorm12_values.invalidHHMMSS,
+        validValues: scorm12_values.validTimespan,
+        invalidValues: scorm12_values.invalidTimespan,
       });
 
       /**
@@ -686,8 +686,8 @@ describe('SCORM 1.2 CMI Tests', () => {
       h.checkValidValues({
         cmi: interaction(),
         fieldName: 'cmi.latency',
-        validValues: scorm12_values.validTimestamp,
-        invalidValues: scorm12_values.invalidTimestamp,
+        validValues: scorm12_values.validTimespan,
+        invalidValues: scorm12_values.invalidTimespan,
       });
 
       it('should export JSON', () => {
@@ -722,7 +722,6 @@ describe('SCORM 1.2 CMI Tests', () => {
     });
 
     describe('CMIInteractionsCorrectResponsesObject Tests', () => {
-
       /**
        * cmi.interactions.n.correct_responses.n object
        */