From 954768ec6162c32c0db8a24092c3655e2ea90e55 Mon Sep 17 00:00:00 2001
From: Jonathan Putney <jputney@noverant.com>
Date: Thu, 27 May 2021 09:11:02 -0400
Subject: [PATCH] GetValue should no longer throw an exception if an error code
 is returned

This was causing issues with JavaScript execution stopping on the exception, preventing further processing in the module. This was especially an issue when the module was trying to get a value that it should have been providing in the first place (looking at you SkillSoft)
---
 .run/Mocha Unit Tests.run.xml | 14 ++++++++++++++
 .run/compile.run.xml          | 12 ++++++++++++
 test/api_helpers.js           |  2 +-
 3 files changed, 27 insertions(+), 1 deletion(-)
 create mode 100644 .run/Mocha Unit Tests.run.xml
 create mode 100644 .run/compile.run.xml

diff --git a/.run/Mocha Unit Tests.run.xml b/.run/Mocha Unit Tests.run.xml
new file mode 100644
index 0000000..222d338
--- /dev/null
+++ b/.run/Mocha Unit Tests.run.xml	
@@ -0,0 +1,14 @@
+<component name="ProjectRunConfigurationManager">
+  <configuration default="false" name="Mocha Unit Tests" type="mocha-javascript-test-runner">
+    <node-interpreter>project</node-interpreter>
+    <node-options />
+    <mocha-package>$PROJECT_DIR$/node_modules/mocha</mocha-package>
+    <working-directory>$PROJECT_DIR$</working-directory>
+    <pass-parent-env>true</pass-parent-env>
+    <ui>bdd</ui>
+    <extra-mocha-options>--watch --require @babel/register</extra-mocha-options>
+    <test-kind>PATTERN</test-kind>
+    <test-pattern>test/**/*.spec.js</test-pattern>
+    <method v="2" />
+  </configuration>
+</component>
\ No newline at end of file
diff --git a/.run/compile.run.xml b/.run/compile.run.xml
new file mode 100644
index 0000000..2877526
--- /dev/null
+++ b/.run/compile.run.xml
@@ -0,0 +1,12 @@
+<component name="ProjectRunConfigurationManager">
+  <configuration default="false" name="compile" type="js.build_tools.npm" nameIsGenerated="true">
+    <package-json value="$PROJECT_DIR$/package.json" />
+    <command value="run" />
+    <scripts>
+      <script value="compile" />
+    </scripts>
+    <node-interpreter value="project" />
+    <envs />
+    <method v="2" />
+  </configuration>
+</component>
\ No newline at end of file
diff --git a/test/api_helpers.js b/test/api_helpers.js
index ad7c818..eee466e 100644
--- a/test/api_helpers.js
+++ b/test/api_helpers.js
@@ -71,7 +71,7 @@ export const checkLMSGetValue = (
       initializeFirst = false,
       initializationValue = '',
       expectedError = 0,
-      errorThrown = true,
+      errorThrown = false,
     }) => {
   describe(`Field: ${fieldName}`, () => {
     const status = expectedError > 0 ? 'fail to' : 'successfully';