From f2637f10b56cf4775b69cb66e1459a59ec32be80 Mon Sep 17 00:00:00 2001 From: Jonathan Putney Date: Mon, 30 Dec 2019 13:19:06 -0500 Subject: [PATCH] Blank string is valid for cmi.core.exit/cmi.exit --- src/cmi/scorm12_cmi.js | 2 +- src/cmi/scorm2004_cmi.js | 2 +- src/constants/field_values.js | 2 ++ 3 files changed, 4 insertions(+), 2 deletions(-) diff --git a/src/cmi/scorm12_cmi.js b/src/cmi/scorm12_cmi.js index 25300f0..803d70a 100644 --- a/src/cmi/scorm12_cmi.js +++ b/src/cmi/scorm12_cmi.js @@ -462,7 +462,7 @@ class CMICore extends BaseCMI { * @param {string} exit */ set exit(exit) { - if (check12ValidFormat(exit, regex.CMIExit)) { + if (check12ValidFormat(exit, regex.CMIExit, true)) { this.#exit = exit; } } diff --git a/src/cmi/scorm2004_cmi.js b/src/cmi/scorm2004_cmi.js index d5c41b3..88dca66 100644 --- a/src/cmi/scorm2004_cmi.js +++ b/src/cmi/scorm2004_cmi.js @@ -235,7 +235,7 @@ export class CMI extends BaseCMI { * @param {string} exit */ set exit(exit) { - if (check2004ValidFormat(exit, regex.CMIExit)) { + if (check2004ValidFormat(exit, regex.CMIExit, true)) { this.#exit = exit; } } diff --git a/src/constants/field_values.js b/src/constants/field_values.js index 9f73e68..c7f22b2 100644 --- a/src/constants/field_values.js +++ b/src/constants/field_values.js @@ -89,6 +89,7 @@ export const scorm12_values = { 'time-out', 'suspend', 'logout', + '', ], invalidExit: [ 'close', @@ -229,6 +230,7 @@ export const scorm2004_values = { 'suspend', 'logout', 'normal', + '', ], invalidExit: [ 'close',